utils: fix ensure_file() to use lstat() instead of stat()#759
Closed
kishansaaai wants to merge 1 commit into
Closed
utils: fix ensure_file() to use lstat() instead of stat()#759kishansaaai wants to merge 1 commit into
kishansaaai wants to merge 1 commit into
Conversation
stat() follows symlinks, making the S_ISLNK(buf.st_mode) check permanently dead code. Switch to lstat() so symlinks are correctly detected and rejected as bind-mount destinations. Fixes containers#733 Signed-off-by: SAI KISHAN A <222060771+kishansaaai@users.noreply.github.com>
kishansaaai
force-pushed
the
fix/733-ensure-file-use-lstat
branch
from
718faf5 to
412b277
Compare
rusty-snake
suggested changes
Jun 6, 2026
Contributor
rusty-snake
left a comment
rusty-snake
left a comment
There was a problem hiding this comment.
Has anything changed from #737?
Comment on lines
514
to
515
| the kernel will accept any non-directory. If it's a symlink, follow | ||
| it and look at the target: again, any non-directory is good enough. |
Author
There was a problem hiding this comment.
Thanks for the review @rusty-snake. I see that #737 already res this by clarifying the comments the stat() behavior was intent for the dangling symlink case, which I had missed. I'll close th Apologies for the noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #733.
ensure_file() intends to reject symlinks as bind-mount destinations
via S_ISLNK(buf.st_mode), but uses stat() which follows symlinks,
making this check permanently dead code.
Fix: replace stat() with lstat() so the symlink check actually works.
Testing
Existing test suite passes. The S_ISLNK branch is now reachable.